Skip to content

feat: add implementation of halfnormal/mean #9613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shubham220420 wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

feat: add implementation of halfnormal/mean #9613

shubham220420 wants to merge 28 commits into from
+1,950 −0

Conversation

@shubham220420
Copy link
Contributor

@shubham220420 shubham220420 commented Jan 7, 2026

Progresses: #9416

Description

What is the purpose of this pull request?

This pull request:

  • This PR adds the mean calculation for half-normal distribution function.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

Yes I took help of AI for creating test cases under the fixtures/julia directory.

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 7, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 7, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/halfnormal/mean $\color{green}166/166$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}166/166$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@shubham220420
fix: linting and header errors
1ae8640
@shubham220420
fix: linting and header errors
d425601
@shubham220420
fix: JavaScript linting errors
14a6709
@shubham220420
fix: add missing import
7eba0df
@shubham220420
fix indentation error in runner.jl
67af003 
Signed-off-by: Shubham <[email protected]>
@shubham220420
fix indentation error in test.js
2cc7feb 
Signed-off-by: Shubham <[email protected]>
@shubham220420
Merge branch 'shubham2204-halfnornmal' of https://github.com/shubham2…
bfd355d 
…20420/stdlib into shubham2204-halfnornmal
@shubham220420
Fix indentation in runner.jl for expected values
456b330 
Signed-off-by: Shubham <[email protected]>
@shubham220420
fix indentation error in test.js
0237bde 
Signed-off-by: Shubham <[email protected]>
@shubham220420
update index.js
05b423b
@shubham220420
Merge branch 'shubham2204-halfnornmal' of https://github.com/shubham2…
fb50db0 
…20420/stdlib into shubham2204-halfnornmal
Planeshifter
Planeshifter requested changes Jan 7, 2026
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged a bunch of issues.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 7, 2026
@shubham220420
Copy link
Contributor Author

shubham220420 commented Jan 7, 2026 •
edited
Loading

thankyou for your reviews sir @Planeshifter , I have applied the requested changes.
Incase any lint error occurs I'll solve it, I've been working on this module from quite few hours now, and will look further tomorrow

@Planeshifter Planeshifter changed the title feat!: add implementation of halfnormal/mean feat: add implementation of halfnormal/mean Jan 7, 2026
Planeshifter
Planeshifter requested changes Jan 8, 2026
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued efforts! Should be ready to land soon.

@shubham220420
Copy link
Contributor Author

shubham220420 commented Jan 8, 2026

I have applied the requested suggestion sir.

Planeshifter
Planeshifter requested changes Jan 9, 2026
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last comments.

@shubham220420
fix: add requested suggestions
724e7bd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: failed
---
@shubham220420
Copy link
Contributor Author

shubham220420 commented Jan 10, 2026 •
edited
Loading

Hey sir I have applied the requested changes.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 10, 2026
@shubham220420
update test.native.js
06d7aed 
Signed-off-by: Shubham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubham220420 @stdlib-bot @Planeshifter